[webkit-reviews] review granted: [Bug 26189] DOM Storage: Changes for Android and macro guards : [Attachment 31054] Lazily create localstorage objects for PageGroups.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 8 18:09:16 PDT 2009
Eric Seidel <eric at webkit.org> has granted Ben Murdoch <benm at google.com>'s
request for review:
Bug 26189: DOM Storage: Changes for Android and macro guards
https://bugs.webkit.org/show_bug.cgi?id=26189
Attachment 31054: Lazily create localstorage objects for PageGroups.
https://bugs.webkit.org/attachment.cgi?id=31054&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
Is it possible to call PageGroup::localStorage() when there are no pages in the
group? Like during destruction when pages have been removed from the group?
Are pages ever removed from a group?
In general this looks fine.
More information about the webkit-reviews
mailing list