[webkit-reviews] review granted: [Bug 23296] add Android platform-specific files to WebCore/platform : [Attachment 31061] new patch part 4 with ChangeLog
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 8 14:36:24 PDT 2009
Eric Seidel <eric at webkit.org> has granted Feng Qian <feng at chromium.org>'s
request for review:
Bug 23296: add Android platform-specific files to WebCore/platform
https://bugs.webkit.org/show_bug.cgi?id=23296
Attachment 31061: new patch part 4 with ChangeLog
https://bugs.webkit.org/attachment.cgi?id=31061&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
It seems:
199 static inline String singleCharacterString(int c)
shoudl take a UChar32 instead of an "int"
So sad more of this code can't be shared between platforms.
Looks sane enough though. When landing, please fix the one nit above.
More information about the webkit-reviews
mailing list