[webkit-reviews] review denied: [Bug 26230] JavascriptURL as frame src crasher. : [Attachment 31056] Cancel requests in ~DocLoader (take2)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 8 13:01:57 PDT 2009


Eric Seidel <eric at webkit.org> has denied Michael Nordman
<michaeln at google.com>'s request for review:
Bug 26230: JavascriptURL as frame src crasher.
https://bugs.webkit.org/show_bug.cgi?id=26230

Attachment 31056: Cancel requests in ~DocLoader (take2)
https://bugs.webkit.org/attachment.cgi?id=31056&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Your patch needs to include a test case.  Even if that test case only crashes
in Chromium.  Your ChangeLog (or at least the bug) should document under which
conditions this crash occurs.  From reading the bug it seems it only occurs in
Chromium?


More information about the webkit-reviews mailing list