[webkit-reviews] review granted: [Bug 20303] [Qt] Key events are not working in frames. : [Attachment 30870] add a layout test to test the fix.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jun 7 06:11:28 PDT 2009


Holger Freyther <zecke at selfish.org> has granted Yongjun Zhang
<yongjun.zhang at nokia.com>'s request for review:
Bug 20303: [Qt] Key events are not working in frames.
https://bugs.webkit.org/show_bug.cgi?id=20303

Attachment 30870: add a layout test to test the fix.
https://bugs.webkit.org/attachment.cgi?id=30870&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
Great. You could make this with one or two lines less of code with a do {}
while construct. Would you be interested in moving this function into the
EventHandler class and make the windows version call that "shared"
implementation. It would be greatly appreciated?


More information about the webkit-reviews mailing list