[webkit-reviews] review denied: [Bug 16148] overflow: hidden with float:left rendering issue : [Attachment 30742] Patch calcPrefWidths (use specified width as min/max pref width when 0).
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Jun 6 13:00:53 PDT 2009
Dave Hyatt <hyatt at apple.com> has denied Jacob Refstrup
<jacob.refstrup at hp.com>'s request for review:
Bug 16148: overflow: hidden with float:left rendering issue
https://bugs.webkit.org/show_bug.cgi?id=16148
Attachment 30742: Patch calcPrefWidths (use specified width as min/max pref
width when 0).
https://bugs.webkit.org/attachment.cgi?id=30742&action=review
------- Additional Comments from Dave Hyatt <hyatt at apple.com>
Pretty sure it's impossible for width to be negative, so once you've changed it
to >= 0 it's equivalent to just not having that in the if statement at all.
Also, you need to patch RenderFlexibleBox::calcPrefWidths, as it has the same
mistake.
More information about the webkit-reviews
mailing list