[webkit-reviews] review granted: [Bug 26148] Unfork RenderThemeChromium{Win, Linux}.{h, cc} : [Attachment 31007] Fix typo and make defaultGUIFont into function again

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jun 6 01:19:26 PDT 2009


Eric Seidel <eric at webkit.org> has granted Albert J. Wong
<ajwong at chromium.org>'s request for review:
Bug 26148: Unfork RenderThemeChromium{Win,Linux}.{h,cc}
https://bugs.webkit.org/show_bug.cgi?id=26148

Attachment 31007: Fix typo and make defaultGUIFont into function again
https://bugs.webkit.org/attachment.cgi?id=31007&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
const String& RenderThemeChromiumSkia::defaultGUIFont() {

{ should be on it's own line.  someone can fix that when landing this.
Also WebKit uses 4 spaces, not 2!
+  static String fontFace("Arial");


If this needed to be compiled on Mac, due to a GCC bug we would need to use
DEFINE_STATIC_LOCAL for:
+  static String fontFace("Arial");
but it does not, so you're fine.

Needs tiny fixes when landing.


More information about the webkit-reviews mailing list