[webkit-reviews] review denied: [Bug 26148] Unfork RenderThemeChromium{Win, Linux}.{h, cc} : [Attachment 30983] Factor out RenderThemeChromiumSkia from just the RenderThemeChromiumLinux portion.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 4 20:50:57 PDT 2009
Eric Seidel <eric at webkit.org> has denied Albert J. Wong <ajwong at chromium.org>'s
request for review:
Bug 26148: Unfork RenderThemeChromium{Win,Linux}.{h,cc}
https://bugs.webkit.org/show_bug.cgi?id=26148
Attachment 30983: Factor out RenderThemeChromiumSkia from just the
RenderThemeChromiumLinux portion.
https://bugs.webkit.org/attachment.cgi?id=30983&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks great!
In response to your IRC question, yes WebKit avoids non pod globals because
they slow down library load/startup time. So you're right that you'll need to
fix defaultGUIFont to use a function or some other solution.
Typo:
+ 1) Createion of a caretBlinkIntervalInternal.
Looks great otherwise.
r- because I'm worried the global constructor could cause build bots to break.
More information about the webkit-reviews
mailing list