[webkit-reviews] review requested: [Bug 26148] Unfork RenderThemeChromium{Win, Linux}.{h, cc} : [Attachment 30983] Factor out RenderThemeChromiumSkia from just the RenderThemeChromiumLinux portion.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 4 20:10:42 PDT 2009
Albert J. Wong <ajwong at chromium.org> has asked for review:
Bug 26148: Unfork RenderThemeChromium{Win,Linux}.{h,cc}
https://bugs.webkit.org/show_bug.cgi?id=26148
Attachment 30983: Factor out RenderThemeChromiumSkia from just the
RenderThemeChromiumLinux portion.
https://bugs.webkit.org/attachment.cgi?id=30983&action=review
------- Additional Comments from Albert J. Wong <ajwong at chromium.org>
Hey Eric, here's another shot.
It's not a pure move, but went through the diff this time and listed all the
non-move changes I made.
The reason the functions were shuffled last time was cause they were moved from
RenderThemeChromiumLinux to RenderThemeChromiumSkia and I was trying to keep
each classes methods together. However, since it's all going to another file
anwyays, no need to worry about that. :)
I don't actually know what the difference between String and AtomicString are
so I just chose String. Let me know if you want me to use the other. I assume
that there WebKit doesn't ban using non-POD data types in globals/statics like
Chromium does?
I'll upload the windows side of this tomorrow.
More information about the webkit-reviews
mailing list