[webkit-reviews] review denied: [Bug 26198] Misc. code cleanup and simplification : [Attachment 30966] RenderTable.cpp - remove superfluous if statements
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 4 20:08:18 PDT 2009
Eric Seidel <eric at webkit.org> has denied Roland Steiner
<rolandsteiner at google.com>'s request for review:
Bug 26198: Misc. code cleanup and simplification
https://bugs.webkit.org/show_bug.cgi?id=26198
Attachment 30966: RenderTable.cpp - remove superfluous if statements
https://bugs.webkit.org/attachment.cgi?id=30966&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
I think we should just turn these into ASSERTS in case we ever change the
Renderer inheritance for TableSections.
Also, we might as well fix the style violation while were here:
+ if (!m_head) {
+ m_head = static_cast<RenderTableSection*>(child);
+ } else {
r- for lack of ChangeLog and nits above.
More information about the webkit-reviews
mailing list