[webkit-reviews] review denied: [Bug 26148] Unfork RenderThemeChromium{Win, Linux}.{h, cc} : [Attachment 30974] Factors out a common RenderThemeChromiumSkia class and makes RenderThemeChromiumLinux and RenderThemeChromiumWin depend on it.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 4 19:27:23 PDT 2009


Eric Seidel <eric at webkit.org> has denied Albert J. Wong <ajwong at chromium.org>'s
request for review:
Bug 26148: Unfork RenderThemeChromium{Win,Linux}.{h,cc}
https://bugs.webkit.org/show_bug.cgi?id=26148

Attachment 30974: Factors out a common RenderThemeChromiumSkia class and makes
RenderThemeChromiumLinux and RenderThemeChromiumWin depend on it.
https://bugs.webkit.org/attachment.cgi?id=30974&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Why re-order paintMediaButtonInternal ?  Leaving it where it was makes the
patch easier to read.

Why re-order menuListInternalPadding?  Same as above...

Why wouldn't this just be a String or an AtomicString?
static const char* defaultGUIFont;
That would save conversions on every use.

Yeah, I think a little shuffling and splitting could make this diff much
smaller.  Hard to review at this size. :(


More information about the webkit-reviews mailing list