[webkit-reviews] review granted: [Bug 13128] Safari not obeying cache header : [Attachment 30930] updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 4 16:25:00 PDT 2009


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 13128: Safari not obeying cache header
https://bugs.webkit.org/show_bug.cgi?id=13128

Attachment 30930: updated patch
https://bugs.webkit.org/attachment.cgi?id=30930&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
(In reply to comment #19)
> The only thing that I want to do is to compare the RFC language to the
> implementation.  (Thanks for adding appropriate comments to the source!) 
> Otherwise, this patch looks great!

I only found one issue with the comments:

>+    // RFC2616 13.3.3
>[...]
>+    // RFC2616 13.3.4

These should be sections 13.2.3 and 13.2.4, respectively.

r=me!


More information about the webkit-reviews mailing list