[webkit-reviews] review cancelled: [Bug 25436] Refactor appCache for use in multi-process browsers : [Attachment 30744] ApplicationCacheFrontend interface and usage (rev 3)

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has cancelled Michael Nordman
<michaeln at google.com>'s request for review:
Bug 25436: Refactor appCache for use in multi-process browsers
https://bugs.webkit.org/show_bug.cgi?id=25436

Attachment 30744: ApplicationCacheFrontend interface and usage (rev 3)
https://bugs.webkit.org/attachment.cgi?id=30744&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
We've discussed the refactoring on IRC for some time, and I think that we have
some agreement on how to move forward.

- ResourceHandle should be left unchanged, as it is primarily just an interface
to platform-specific code.
- A new class should be introduced, that will incorporate both network and
appcache loading. This is pretty much what Michael suggested above, in fact.
- Application cache implementation should not use global data, so that it could
support Chrome's incognito mode.
- As much as possible, we should move in small steps, and avoid ifdefs that are
forking the logic.

Getting appcache work on Chrome is definitely a priority. What needs to be done
is figuring out what small incremental steps that are needed to get it work can
be done separately. One example we could come up with was getting rid of global
data in appcache - with luck, there is a path with very little divergence in
logic needed at any point (and once Chrome works, further refactoring will
remove the rest).