[webkit-reviews] review denied: [Bug 26187] Canvas initial lineWidth not in sync with graphics backends. : [Attachment 30947] patch w/ layout test

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Dean McNamee <deanm at chromium.org>'s
request for review:
Bug 26187: Canvas initial lineWidth not in sync with graphics backends.
https://bugs.webkit.org/show_bug.cgi?id=26187

Attachment 30947: patch w/ layout test
https://bugs.webkit.org/attachment.cgi?id=30947&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
The fix itself looks good but i don't like the layout test.  You should look at
the design of the more modern canvas tests -- they're basically the same
structure as JS ones so find a test which has the following

fast/canvas/test-name.html // html document will just have some boiler plate
that includes a couple of js files, resoureces/test-name.js and then another js
file
fast/canvas/resources/test-name.js // The actual test itself

I *think* the isPointInPath tests cases will be of this newer style.   The
newer style is vastly more useful as we use getImagedata to anaylse the result
of drawing rather than relying on pixel comparisons.  This is especially
benefical given people typically do no run pixel tests, but also because it's
much easier to see what is being tested.

--Oliver