[webkit-reviews] review denied: [Bug 26148] Unfork RenderThemeChromium{Win, Linux}.{h, cc} : [Attachment 30884] copy RenderThemeChromiumLinux -> RenderThemeChromiumSkia

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 4 12:14:01 PDT 2009


Eric Seidel <eric at webkit.org> has denied Albert J. Wong <ajwong at chromium.org>'s
request for review:
Bug 26148: Unfork RenderThemeChromium{Win,Linux}.{h,cc}
https://bugs.webkit.org/show_bug.cgi?id=26148

Attachment 30884: copy RenderThemeChromiumLinux -> RenderThemeChromiumSkia
https://bugs.webkit.org/attachment.cgi?id=30884&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I think this would be less error-prone if you renamed the class inside
RenderThemeChromiumLinux.* first.  Then you could make Windows depend on it. 
And then you could finally move the file instead of copying it, as the last
step.  If you feel strongly this order is better, that's OK with me, but you'll
just have to be sure to check extra careful at the end to make sure no other
modifications to the file slipped in during your move...


More information about the webkit-reviews mailing list