[webkit-reviews] review granted: [Bug 26061] [SKIA] Crash when filling an empty pattern : [Attachment 30735] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 4 09:05:16 PDT 2009
Eric Seidel <eric at webkit.org> has granted Dean McNamee <deanm at chromium.org>'s
request for review:
Bug 26061: [SKIA] Crash when filling an empty pattern
https://bugs.webkit.org/show_bug.cgi?id=26061
Attachment 30735: patch
https://bugs.webkit.org/attachment.cgi?id=30735&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
The patch looks fine.
I would have used a named constant for the color. I'm surprised that skia
doesn't have a "transparent" constant that you can return instead of having to
manually construct a color.
Color::transparent is identical, and is guaranteed to be the right format due
to COMPILE_ASSERT checks in ColorSkia.cpp.
Tab indent should be 4 spaces, not 2.
Those are both nits someone could fix when landing.
More information about the webkit-reviews
mailing list