[webkit-reviews] review granted: [Bug 25710] HTML5 Database stops executing transactions if the URL hash changes while a transaction is open and an XHR is in progress. : [Attachment 30864] Fix build bustage.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 4 07:35:40 PDT 2009
Alexey Proskuryakov <ap at webkit.org> has granted Ben Murdoch <benm at google.com>'s
request for review:
Bug 25710: HTML5 Database stops executing transactions if the URL hash changes
while a transaction is open and an XHR is in progress.
https://bugs.webkit.org/show_bug.cgi?id=25710
Attachment 30864: Fix build bustage.
https://bugs.webkit.org/attachment.cgi?id=30864&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
Based on Darin's earlier review, this look good for landing
+ * loader/DocumentLoader.cpp:
+ (WebCore::DocumentLoader::stopLoading):
+ * loader/DocumentLoader.h:
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::stopLoading):
+ (WebCore::FrameLoader::stopAllLoaders):
+ * loader/FrameLoader.h:
+ * loader/FrameLoaderTypes.h:
+ (WebCore::):
+ * page/Page.cpp:
+ (WebCore::Page::goToItem):
+ * WebCore.base.exp:
We much prefer detailed per-function comments in ChangeLogs.
More information about the webkit-reviews
mailing list