[webkit-reviews] review granted: [Bug 26174] [Chromium] Change scrollbar theme code to use different classes on Windows and Linux : [Attachment 30926] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 3 15:32:48 PDT 2009
Eric Seidel <eric at webkit.org> has granted Adam Langley <agl at chromium.org>'s
request for review:
Bug 26174: [Chromium] Change scrollbar theme code to use different classes on
Windows and Linux
https://bugs.webkit.org/show_bug.cgi?id=26174
Attachment 30926: patch
https://bugs.webkit.org/attachment.cgi?id=30926&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
spelling:
6 Windows and Linux rather than suppling symbols. The ScrollbarTheme
I think you meant supplying.
I know you're just moving, but we don't name arguments when the names don't add
anything:
42 virtual void paintTrackPiece(GraphicsContext* gc, Scrollbar*
scrollbar, const IntRect& rect, ScrollbarPart partType);
43 virtual void paintButton(GraphicsContext* gc, Scrollbar* scrollbar,
const IntRect& rect, ScrollbarPart partType);
44 virtual void paintThumb(GraphicsContext* gc, Scrollbar* scrollbar,
const IntRect& rect);
Looks sane to me. r+ you can fix the above nits when landing.
More information about the webkit-reviews
mailing list