[webkit-reviews] review requested: [Bug 26030] [Chromium] Chromium Linux ignores background color on <select>. : [Attachment 30920] patch

[bugzilla-daemon at webkit.org]

Adam Langley <agl at chromium.org> has asked Eric Seidel <eric at webkit.org> for
review:
Bug 26030: [Chromium] Chromium Linux ignores background color on <select>.
https://bugs.webkit.org/show_bug.cgi?id=26030

Attachment 30920: patch
https://bugs.webkit.org/attachment.cgi?id=30920&action=review

------- Additional Comments from Adam Langley <agl at chromium.org>
Next attempt:

This time we remove all the magic colour values from the paintButtonLike
function, except for a fallback colour. For painting <select>s and buttons, we
generate the family of colours needed by converting to HSL and changing the
luminance.

With this in hand, we set the CSS ButtonFace colour and the <select>
background-color and everything works out exactly the way is used to, except
that <select>'s with background colours are now handled correctly.

With this code, we could also handling drawing buttons with background-colors,
but that's something for another patch.