[webkit-reviews] review denied: [Bug 26037] [Skia] Canvas globalAlpha property not applied to drawImage method : [Attachment 30889] Use the alpha channel when painting images in skia.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 3 10:37:06 PDT 2009
Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Anand K. Mistry
<akmistry at gmail.com>'s request for review:
Bug 26037: [Skia] Canvas globalAlpha property not applied to drawImage method
https://bugs.webkit.org/show_bug.cgi?id=26037
Attachment 30889: Use the alpha channel when painting images in skia.
https://bugs.webkit.org/attachment.cgi?id=30889&action=review
------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
> + int alpha = roundf(platformContext->getAlpha() * 256);
> + if (alpha > 255)
> + alpha = 255;
> + else if (alpha < 0)
> + alpha = 0;
> + paint.setAlpha(alpha);
4 spaces indent.
Looks great otherwise.
More information about the webkit-reviews
mailing list