[webkit-reviews] review cancelled: [Bug 25562] Potential crash after ApplicationCacheStorage::storeNewestCache() fails. : [Attachment 30880] 30702: Fix for 25562 (take 5)
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 3 04:16:41 PDT 2009
Andrei Popescu <andreip at google.com> has cancelled Andrei Popescu
<andreip at google.com>'s request for review:
Bug 25562: Potential crash after ApplicationCacheStorage::storeNewestCache()
fails.
https://bugs.webkit.org/show_bug.cgi?id=25562
Attachment 30880: 30702: Fix for 25562 (take 5)
https://bugs.webkit.org/attachment.cgi?id=30880&action=review
------- Additional Comments from Andrei Popescu <andreip at google.com>
Small improvement: the logger object needs to live inside storeNewestCache() in
order to be able to also catch the (unlikely) case where the "Update the newest
cache in the group" step fails.
Also improved the comments and removed some whitespace changes.
More information about the webkit-reviews
mailing list