[webkit-reviews] review denied: [Bug 17375] [Gtk] Set user-agent from application : [Attachment 30885] WebView API methods to get/set global "user-agent" property using Soup Session

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied 's request for review:
Bug 17375: [Gtk] Set user-agent from application
https://bugs.webkit.org/show_bug.cgi?id=17375

Attachment 30885: WebView API methods to get/set global "user-agent" property
using Soup Session
https://bugs.webkit.org/attachment.cgi?id=30885&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
Hey, thanks for the patch. There are a bunch of indentation problems in your
patch (tabs vs spaces, most probably), and it is really the wrong solution to
the problem. The most proeminent issue being that you are messing with global
stuff using WebView API, which is supposed to act on a per-WebView basis, so
that's no good. We probably want to do what Xan proposed, to move forward. By
the way, you need to mark your patches with '?' in the review combo box, if you
want them to catch our attention. You were lucky I'm watching this bug report
=)