[webkit-reviews] review requested: [Bug 25319] caret does not paint after type in characters in right aligned div or after delete all characters in RTL div or 0px right padding RTL textarea : [Attachment 30887] patch w/ layout test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 2 18:00:29 PDT 2009


Xiaomei Ji <xji at chromium.org> has asked  for review:
Bug 25319: caret does not paint after type in characters in right aligned div
or after delete all characters in RTL div or 0px right padding RTL textarea
https://bugs.webkit.org/show_bug.cgi?id=25319

Attachment 30887: patch w/ layout test
https://bugs.webkit.org/attachment.cgi?id=30887&action=review

------- Additional Comments from Xiaomei Ji <xji at chromium.org>
updated patch per Ojan's suggestion:
1. change the "if" to "switch" in RenderText.cpp for better readability
2. using dumpAsText() and textInputController.firstRectForCharacterRange(i, 0)
for layout test
3. remove pixel tests which are not necessary, and remove "font-size:2000%"
which is for pixel test only.


More information about the webkit-reviews mailing list