[webkit-reviews] review requested: [Bug 26148] Unfork RenderThemeChromium{Win, Linux}.{h, cc} : [Attachment 30884] copy RenderThemeChromiumLinux -> RenderThemeChromiumSkia
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 2 15:47:52 PDT 2009
Albert J. Wong <ajwong at chromium.org> has asked for review:
Bug 26148: Unfork RenderThemeChromium{Win,Linux}.{h,cc}
https://bugs.webkit.org/show_bug.cgi?id=26148
Attachment 30884: copy RenderThemeChromiumLinux -> RenderThemeChromiumSkia
https://bugs.webkit.org/attachment.cgi?id=30884&action=review
------- Additional Comments from Albert J. Wong <ajwong at chromium.org>
This patch modifies the copied RenderThemeChromiumLinux in the following ways:
(1) RenderThemeChromiumLinux renamed RenderThemeChromiumSkia
(2) Some trailing whitespace was deleted.
(3) RenderThemer* theme(){} was removed. This will need to stay in
RenderThemeChromiumLinux after all since this is how the compilation determines
which version of render theme to instantiate.
(4) Moved the destructor definition into the implementation file, and added a
missing "virtual".
(5) Fixed an #endif comment.
More information about the webkit-reviews
mailing list