[webkit-reviews] review granted: [Bug 26028] [Chromium] Chromium Linux leaves unpainted areas on very small scrollbars. : [Attachment 30681] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 2 15:37:47 PDT 2009
Eric Seidel <eric at webkit.org> has granted Adam Langley <agl at chromium.org>'s
request for review:
Bug 26028: [Chromium] Chromium Linux leaves unpainted areas on very small
scrollbars.
https://bugs.webkit.org/show_bug.cgi?id=26028
Attachment 30681: patch
https://bugs.webkit.org/attachment.cgi?id=30681&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
The change is fine. Please comment the code a bit more to explain what it's
doing. I found:
int thickness =
a little strange until you explained to me that all scrollbar buttons are
square.
Likewise it would be nice to explain why Chromium linux is different from
Chromium Win here.
I don't need to see this again. I trust you can come up with some nice
comments to document this whenlanding. Thanks!
More information about the webkit-reviews
mailing list