[webkit-reviews] review requested: [Bug 26030] [Chromium] Chromium Linux ignores background color on <select>. : [Attachment 30881] patch

[bugzilla-daemon at webkit.org]

Adam Langley <agl at chromium.org> has asked Eric Seidel <eric at webkit.org> for
review:
Bug 26030: [Chromium] Chromium Linux ignores background color on <select>.
https://bugs.webkit.org/show_bug.cgi?id=26030

Attachment 30881: patch
https://bugs.webkit.org/attachment.cgi?id=30881&action=review

------- Additional Comments from Adam Langley <agl at chromium.org>
Changes:

1) Color::rgb does indeed return a value which is
   compatible. However, it seems be a bit of a leap that the
   internal format of both Color and SkColor is register
   ARGB. Other platforms define specific constructors in
   Color. However, both RGBA32 and SkColor unwrap to an
   unsigned int, so we can't do that here.

   I've used .rgb() because it works and it's cleaner. I
   guess layout tests will catch if either side ever
   changes.

2) html4.css was specifiying a default background-color for
   buttons which meant that we could never tell if the page
   was setting one (which we should observe) or not (in
   which case we should draw our default button). So I added
   a CSS snippet to override this.