[webkit-reviews] review denied: [Bug 26030] [Chromium] Chromium Linux ignores background color on <select>. : [Attachment 30682] patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Adam Langley <agl at chromium.org>'s
request for review:
Bug 26030: [Chromium] Chromium Linux ignores background color on <select>.
https://bugs.webkit.org/show_bug.cgi?id=26030

Attachment 30682: patch
https://bugs.webkit.org/attachment.cgi?id=30682&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Style issues.  no { } on single line ifs.

Don't we have a more efficient way to set this?

paint.setARGB(o->style()->backgroundColor().alpha(),
o->style()->backgroundColor().red(), o->style()->backgroundColor().green(),
o->style()->backgroundColor().blue());

There should be a way to pass a Color object to a SkPaint, I'm sure we have
such a function somewhere.  color has a .rgb() accessor which probably returns
a skpaint compatible int.