[webkit-reviews] review denied: [Bug 25904] [Chromium] Mac Chromium HTML selects don't initialize their widths : [Attachment 30758] Fix for the popup width initialization bug and a manual regression test.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 1 13:51:43 PDT 2009


Eric Seidel <eric at webkit.org> has denied Paul Godavari <paul at chromium.org>'s
request for review:
Bug 25904: [Chromium] Mac Chromium HTML selects don't initialize their widths
https://bugs.webkit.org/show_bug.cgi?id=25904

Attachment 30758: Fix for the popup width initialization bug and a manual
regression test.
https://bugs.webkit.org/attachment.cgi?id=30758&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I don't understand what your test is testing.  Why does it need 26 options? 
Ideally the test should have the minimum amount of content to get the point
across and no more.

Why is document.elementAtPoint() insufficient for this test?  I take it the
<select> element draws at the right place, but the popup itself (a window over
the top of Chromium) does not?	In that case, I can see that this would be
untestable, but you should explain that in your ChangeLog.


More information about the webkit-reviews mailing list