[webkit-reviews] review requested: [Bug 10930] WebKit could benefit from a JavaScript live object profiler : [Attachment 30834] Adds live object profiling capabilities

[bugzilla-daemon at webkit.org]

Horia Olaru <olaru at adobe.com> has asked  for review:
Bug 10930: WebKit could benefit from a JavaScript live object profiler
https://bugs.webkit.org/show_bug.cgi?id=10930

Attachment 30834: Adds live object profiling capabilities
https://bugs.webkit.org/attachment.cgi?id=30834&action=review

------- Additional Comments from Horia Olaru <olaru at adobe.com>
This version of the patch no longer introduces significant performance
regressions.
Sunspider results are:
http://pastie.org/496608

** TOTAL **:	       -		 731.9ms +/- 0.1%   731.2ms +/- 0.1% 

The live object profiling is disabled by default when profiling is enabled. An
explicit action must be performed by the user to enabled it. I have added a
temporary function on the console object that enables or disables live memory
profiling, until this functionality is hooked into the UI. Note that profiling
still needs to be enabled before enabling live object profiling.