[webkit-reviews] review denied: [Bug 27619] [multi-patch] Switch wx to using waf for builds : [Attachment 33375] Fix for when running DerivedSources.make from a subdir of JSCore

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 31 22:26:30 PDT 2009


Jan Alonzo <jmalonzo at gmail.com> has denied Kevin Ollivier
<kevino at theolliviers.com>'s request for review:
Bug 27619: [multi-patch] Switch wx to using waf for builds
https://bugs.webkit.org/show_bug.cgi?id=27619

Attachment 33375: Fix for when running DerivedSources.make from a subdir of
JSCore
https://bugs.webkit.org/attachment.cgi?id=33375&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
>  docs/bytecode.html: make-bytecode-docs.pl Interpreter.cpp 
> -	perl $^ $@
> +	perl $^ $(JavaScriptCore)/$@

VPATH is already set to the appropriate directories so I don't see why you need
this, and why it needs to apply to Interpreter.cpp only. Can you please attach
the build log or the error you're getting here as well? 

r- for now because of this.


More information about the webkit-reviews mailing list