[webkit-reviews] review denied: [Bug 27424] adding ConvertToGCharPrivate.h : [Attachment 33388] addressing review comments, decision on "Private" in name still outstanding decision?

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Luke Kenneth Casson Leighton
<lkcl at lkcl.net>'s request for review:
Bug 27424: adding ConvertToGCharPrivate.h
https://bugs.webkit.org/show_bug.cgi?id=27424

Attachment 33388: addressing review comments, decision on "Private" in name
still outstanding decision?
https://bugs.webkit.org/attachment.cgi?id=33388&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Most of the rest of WebCore follows the "copy rule", which would name these
with "copy" in their name since you're copying the data, or create.

copyAsGchar()
or
createGcharFromString()

I've never seen this:
23 /*
 24  * added under bug #27424 - 19jul2009
 25  */

Seems superfluous, given that we have a version control system.

I'm also not sure what Private_h is for, but that was discussed in the long
comments above (which I admit to not reading, given their length).

So overall these look fine.  I'm not a huge fan of the convert name, but it's
also not a dealbreaker.

Since you're not a committer yet, r- for the unneeded comment.