[webkit-reviews] review granted: [Bug 18599] resolve-ChangeLogs doesn't work with relative paths : [Attachment 33912] Implement VCSUtils::chdirReturningRelativePath()

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 18599: resolve-ChangeLogs doesn't work with relative paths
https://bugs.webkit.org/show_bug.cgi?id=18599

Attachment 33912: Implement VCSUtils::chdirReturningRelativePath()
https://bugs.webkit.org/attachment.cgi?id=33912&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
you don't need qw() just (), iirc qw() == (), or?

I've never seen this line actually do anything:
    @EXPORT	 = qw(&chdirReturningRelativePath &determineSVNRoot
&determineVCSRoot &isGit &isGitDirectory &isSVN &isSVNDirectory
&makeFilePathRelative
I think we just have it to comply with perl hear-say. ;)

LGTM.