[webkit-reviews] review granted: [Bug 27844] SVG Filter and linearRGB, sRGB platform support : [Attachment 33796] linearRGB, sRGB support for platforms

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Dirk Schulze <krit at webkit.org>'s
request for review:
Bug 27844: SVG Filter and linearRGB, sRGB platform support
https://bugs.webkit.org/show_bug.cgi?id=27844

Attachment 33796: linearRGB, sRGB support for platforms
https://bugs.webkit.org/attachment.cgi?id=33796&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
> +void ImageBuffer::transformColorSpace(ImageColorSpace srcColorSpace,
ImageColorSpace dstColorSpace)
> +{
...
> +    if (dstColorSpace == LinearRGB) {
> +	   if (m_linearRgbLUT.isEmpty()) {
...
> +	   lookUpTable = m_linearRgbLUT;
> +    }
> +    if (dstColorSpace == DeviceRGB) {
...
> +    }
should be 'else if' here

> +	   case LinearRGB:
> +			colorSpace =
CGColorSpaceCreateWithName(kCGColorSpaceGenericRGBLinear);
indenting :D

I share eric's concern about the placement of the colour matching logic --
logically it should be in GraphicsContext, but i don't think it's feasible to
do the required logic to ensure that behaviour is correct outside of the
underlying graphics library so this placement seems the only place it can
really go for now.