[webkit-reviews] review granted: [Bug 27873] [Patch] Fix compile error for ambigous call to abs() : [Attachment 33869] compile fix for ambigous call to abs()

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Harald Fernengel
<harry at kdevelop.org>'s request for review:
Bug 27873: [Patch] Fix compile error for ambigous call to abs()
https://bugs.webkit.org/show_bug.cgi?id=27873

Attachment 33869: compile fix for ambigous call to abs()
https://bugs.webkit.org/attachment.cgi?id=33869&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Another approach we use for issues like this is to put code in MathExtras.h to
work around platform differences. Take a look at MathExtras.h to see what I
mean.

But this change seems OK.

I think the change log is not so good. It says "fix compilation" which is far
too vague. The bug mentions the QNX platform and the change log should too.

I'm going to say r=me, though, because this seems like a good fix.