[webkit-reviews] review granted: [Bug 27866] [Qt] Initialize HTML5 Application Cache for QtWebKit to a sensible default : [Attachment 33856] proposed patch

[bugzilla-daemon at webkit.org]

Tor Arne Vestbø <vestbo at webkit.org> has granted Laszlo Gombos
<laszlo.1.gombos at nokia.com>'s request for review:
Bug 27866: [Qt] Initialize HTML5 Application Cache for QtWebKit to a sensible
default
https://bugs.webkit.org/show_bug.cgi?id=27866

Attachment 33856: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33856&action=review

------- Additional Comments from Tor Arne Vestbø <vestbo at webkit.org>
Looks good! A minor nitpick, just fix before landing:

> +static void WebKitInitializeApplicationCachePathIfNecessary()

Should be named initializeApplicationCachePathIfNecessary(), ie no WebKit
prefix, and start with lower-case.

Actually this is not in the coding style guidelines, but I think the lower case
variant is more prevalent.