[webkit-reviews] review granted: [Bug 27876] Expose the Offline Web Application Cache API in the Qt API : [Attachment 33873] Add API to Qt for exposing the webcache

[bugzilla-daemon at webkit.org]

Tor Arne Vestbø <vestbo at webkit.org> has granted Kenneth Rohde Christiansen
<kenneth.christiansen at openbossa.org>'s request for review:
Bug 27876: Expose the Offline Web Application Cache API in the Qt API
https://bugs.webkit.org/show_bug.cgi?id=27876

Attachment 33873: Add API to Qt for exposing the webcache
https://bugs.webkit.org/attachment.cgi?id=33873&action=review

------- Additional Comments from Tor Arne Vestbø <vestbo at webkit.org>
looks good, but we have to do an api review of all of this offline/cache stuff
before the release. a few nitpicks:

> @@ -358,7 +358,6 @@ QWebSettings::QWebSettings()
>      d->attributes.insert(QWebSettings::LocalStorageDatabaseEnabled, true);
>      d->attributes.insert(QWebSettings::LocalContentCanAccessRemoteUrls,
true);
>      d->offlineStorageDefaultQuota = 5 * 1024 * 1024;
> -
>  }

Whitespace change, please remove.

> @@ -785,10 +784,17 @@ qint64 QWebSettings::offlineStorageDefaultQuota()
>  }
>  
>  /*
> -    \internal
> +    \since 4.6
>      \relates QWebSettings
>  
>      Sets the path for HTML5 offline web application cache storage to \a
path.

Please add linebreak here.

> +    An application cache acts like an HTTP cache in some sense. For
documents
> +    that use the application cache via JavaScript, the loader mechinery will

> +    first ask the application cache for the contents, before hitting the
> +    network.