[webkit-reviews] review granted: [Bug 27792] [GTK] new-window-policy-decision-requested provides no information about the target frame : [Attachment 33779] Updated patch 2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 30 17:08:54 PDT 2009


Jan Alonzo <jmalonzo at gmail.com> has granted Martin Robinson
<martin.james.robinson at gmail.com>'s request for review:
Bug 27792: [GTK] new-window-policy-decision-requested provides no information
about the target frame
https://bugs.webkit.org/show_bug.cgi?id=27792

Attachment 33779: Updated patch 2
https://bugs.webkit.org/attachment.cgi?id=33779&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
> +    g_object_class_install_property(objectClass, PROP_TARGET_FRAME,
> +				       g_param_spec_string("target-frame",
> +							   _("Target frame"),
> +							   _("The target frame
for the navigation"),
> +							   "",
> +							  
(GParamFlags)(WEBKIT_PARAM_READWRITE | G_PARAM_CONSTRUCT_ONLY)));

This should be initialized to NULL.

r=me. I'll fixed the nit prior to landing.


More information about the webkit-reviews mailing list