[webkit-reviews] review granted: [Bug 27821] ApplicationCacheHost refactoring : [Attachment 33843] class ApplicationCacheHost rev4
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 30 15:46:07 PDT 2009
Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Michael Nordman
<michaeln at google.com>'s request for review:
Bug 27821: ApplicationCacheHost refactoring
https://bugs.webkit.org/show_bug.cgi?id=27821
Attachment 33843: class ApplicationCacheHost rev4
https://bugs.webkit.org/attachment.cgi?id=33843&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebCore/loader/appcache/DOMApplicationCache.cpp
...
> + switch (eventType) {
> + case CHECKING_EVENT:
> + return eventNames().checkingEvent;
> + case ERROR_EVENT:
nit: I forgot to mention that the style guide says to not indent
the cases. I'll take care of this before committing the patch.
R=me
More information about the webkit-reviews
mailing list