[webkit-reviews] review granted: [Bug 27847] bugzilla-tool post-commits trunk..head errors out : [Attachment 33832] First attempt

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Eric Seidel
<eric at webkit.org>'s request for review:
Bug 27847: bugzilla-tool post-commits trunk..head errors out
https://bugs.webkit.org/show_bug.cgi?id=27847

Attachment 33832: First attempt
https://bugs.webkit.org/attachment.cgi?id=33832&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>

> +    # This function supports the following argument formats:
> +    # no args : rev-list trunk..HEAD
> +    # A..B	 : rev-list A..B
> +    # A...B	 : error!
> +    # A B	 : [A, B]  (different from git diff, which would use "rev-list
A..B")
> +    def commit_ids_from_commitish_arguments(self, args):
> +	   if not len(args):
> +	       args.append('trunk..HEAD')
> +
> +	   commit_ids = []
> +	   for commitish in args:
> +	       if '...' in commitish:
> +		   error("'...' is not supported (found in %s). Did you mean
'..'?" % commitish)
> +	       elif '..' in commitish:
> +		   commit_ids += self.run_command(['git', 'rev-list',
commitish]).splitlines()
> +	       else:
> +		   commit_ids.append(commitish)
> +	   return commit_ids

I think individual commits should still be passed through git rev-parse:

> +	       else:
> +		   commit_ids += self.run_command(['git', 'rev-parse',
'--revs-only', commitish]).splitlines()

This allows you to specify a branch name or a tag name that turns into a single
commit.

r=me with this change. Everything else looks good.