[webkit-reviews] review denied: [Bug 27852] Add --minimal option to webkit-build : [Attachment 33812] Add --minimal option to webkit-build (try 3)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 30 13:17:13 PDT 2009


Adam Roben (aroben) <aroben at apple.com> has denied Jakob Petsovits
<jpetso at gmx.at>'s request for review:
Bug 27852: Add --minimal option to webkit-build
https://bugs.webkit.org/show_bug.cgi?id=27852

Attachment 33812: Add --minimal option to webkit-build (try 3)
https://bugs.webkit.org/attachment.cgi?id=33812&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
I think it would be better and clearer for --minimal to be parsed like all the
other options. After the GetOptions call, if $minimal is true you can just loop
over @features and set all the values that don't match the default to 0.


More information about the webkit-reviews mailing list