[webkit-reviews] review canceled: [Bug 27821] ApplicationCacheHost refactoring : [Attachment 33759] class ApplicationCacheHost rev2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 30 12:58:49 PDT 2009


Michael Nordman <michaeln at google.com> has canceled Michael Nordman
<michaeln at google.com>'s request for review:
Bug 27821: ApplicationCacheHost refactoring
https://bugs.webkit.org/show_bug.cgi?id=27821

Attachment 33759: class ApplicationCacheHost rev2
https://bugs.webkit.org/attachment.cgi?id=33759&action=review

------- Additional Comments from Michael Nordman <michaeln at google.com>
For whatever reason...

private:
    friend class RefCounted<DOMApplicationCache>;
    ~DOMApplicationCache() {}

... doesn't compile with msvc (the RefCounted base class does not have access
to the dtor).  Removing the 'class' keyword does compile with msvc, but then
gcc is unhappy about that. So... bailing on hiding the dtor, moved it to the
public section (which is generally how webcore refcounted classes are).

no other changes


More information about the webkit-reviews mailing list