[webkit-reviews] review denied: [Bug 27706] WebCore NPAPI implementations should share more code : [Attachment 33536] Join the various versions of PluginView::stop() into one shared implementation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 30 12:49:08 PDT 2009


X-Bugzilla-Type: request
In-Reply-To: <bug-27706-0 at https.bugs.webkit.org/>
References: <bug-27706-0 at https.bugs.webkit.org/>

Anders Carlsson <andersca at apple.com> has denied Tor Arne Vestbø
<vestbo at webkit.org>'s request for review:
Bug 27706: WebCore NPAPI implementations should share more code
https://bugs.webkit.org/show_bug.cgi?id=27706

Attachment 33536: Join the various versions of PluginView::stop() into one
shared implementation

https://bugs.webkit.org/attachment.cgi?id=33536&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
This looks very good, although it should use our PLATFORM defines instead of
those from npapi.h Marking r- for this reason.


More information about the webkit-reviews mailing list