[webkit-reviews] review requested: [Bug 27851] Fix compiler warning : [Attachment 33803] bmpwarning.patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 30 12:33:17 PDT 2009


Xan Lopez <xan.lopez at gmail.com> has asked  for review:
Bug 27851: Fix compiler warning
https://bugs.webkit.org/show_bug.cgi?id=27851

Attachment 33803: bmpwarning.patch
https://bugs.webkit.org/attachment.cgi?id=33803&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
GCC does not like multi-character character constants, so it produces the
following warning for BMPImageDecoder.cpp:

  CXX	 WebCore/platform/image-decoders/bmp/libWebCore_la-BMPImageDecoder.lo
../../WebCore/platform/image-decoders/bmp/BMPImageDecoder.cpp:128:16: warning:
multi-character character constant

The attached patch fixes the warning, but since this might be a bit
controversial *and* I can't run the tests to verify that this does not break
anything (they all fail with 'timed out' now, something must be broken
somewhere...), I'm opening a bug for this.


More information about the webkit-reviews mailing list