[webkit-reviews] review granted: [Bug 27772] PopupMenuQt lacks disabled and selected support : [Attachment 33795] Patch with updated style / model check.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 30 11:58:27 PDT 2009
Adam Treat <treat at kde.org> has granted Mike Fenton
<mike.fenton at torchmobile.com>'s request for review:
Bug 27772: PopupMenuQt lacks disabled and selected support
https://bugs.webkit.org/show_bug.cgi?id=27772
Attachment 33795: Patch with updated style / model check.
https://bugs.webkit.org/attachment.cgi?id=33795&action=review
------- Additional Comments from Adam Treat <treat at kde.org>
> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> +
> + if (model && !client()->itemIsEnabled(i))
> + model->item(i)->setEnabled(false);
> +
> + if (client()->itemIsSelected(i))
> + m_popup->setCurrentIndex(i);
> + }
Indentation is not quite right, but I'll fix it when I land. Otherwise r=me!
More information about the webkit-reviews
mailing list