[webkit-reviews] review denied: [Bug 27842] Implement GraphicsContext::fillRoundRect() for WINCE port : [Attachment 33793] patch to implement fillRoundRect
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 30 11:35:51 PDT 2009
George Staikos <staikos at kde.org> has denied review:
Bug 27842: Implement GraphicsContext::fillRoundRect() for WINCE port
https://bugs.webkit.org/show_bug.cgi?id=27842
Attachment 33793: patch to implement fillRoundRect
https://bugs.webkit.org/attachment.cgi?id=33793&action=review
------- Additional Comments from George Staikos <staikos at kde.org>
No need to include "Written by" in this patch and please use the
proper/consistent email address
You should use 0 instead of NULL.
You have braces around IntersectClipRect twice where the coding guidelines say
there should not be (not that I agree...)
The rest seems fine.
More information about the webkit-reviews
mailing list