[webkit-reviews] review granted: [Bug 27774] [Gtk] Code cleanup in MediaPlayerPrivateGStreamer.cpp|h and VideoSinkGStreamer.cpp|h : [Attachment 33789] v0.4.1 - code style fixes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 30 09:55:49 PDT 2009


Gustavo Noronha (kov) <gns at gnome.org> has granted Antonio Gomes (tonikitoo)
<tonikitoo at gmail.com>'s request for review:
Bug 27774: [Gtk] Code cleanup in MediaPlayerPrivateGStreamer.cpp|h and
VideoSinkGStreamer.cpp|h
https://bugs.webkit.org/show_bug.cgi?id=27774

Attachment 33789: v0.4.1 - code style fixes
https://bugs.webkit.org/attachment.cgi?id=33789&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
> -    } else {
> +    } else
>	   g_object_set(G_OBJECT(m_playBin), "volume", m_volume, NULL);
> -    }
> +
>  }

I'd remove this line.

> -	       LOG_VERBOSE(Media, "m_source is NULL");
> +	       LOG_VERBOSE(Media, "m_source is 0");

I think you want to keep this as NULL here.

Other than that looks good.


More information about the webkit-reviews mailing list