[webkit-reviews] review denied: [Bug 27124] let me *edit* css styles in the web inspector. : [Attachment 33783] Edit CSS Selectors

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 30 08:32:43 PDT 2009


Timothy Hatcher <timothy at hatcher.name> has denied Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 27124: let me *edit* css styles in the web inspector.
https://bugs.webkit.org/show_bug.cgi?id=27124

Attachment 33783: Edit CSS Selectors
https://bugs.webkit.org/attachment.cgi?id=33783&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
> +	   for (var i = 0, len = parentRules.length; i < len; ++i) {
> +	   for (var i = 0, len = nodes.length; i < len; ++i) {

We prefer to spell out variables like length.

You need to add all the new UIStrings to localizedString.js

Awesome work!


More information about the webkit-reviews mailing list