[webkit-reviews] review granted: [Bug 27651] [Qt] QWebPluginDatabase API : [Attachment 33766] Allow to explicitly choose a preferred plugin for a mimetype - r3.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 30 05:51:07 PDT 2009
Simon Hausmann <hausmann at webkit.org> has granted Jakub Wieczorek
<faw217 at gmail.com>'s request for review:
Bug 27651: [Qt] QWebPluginDatabase API
https://bugs.webkit.org/show_bug.cgi?id=27651
Attachment 33766: Allow to explicitly choose a preferred plugin for a mimetype
- r3.
https://bugs.webkit.org/attachment.cgi?id=33766&action=review
------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
r=me
+ if (plugin && !plugin->mimeToExtensions().contains(mimeType))
I would formulate this one the other way around:
if (!plugin || plugin->mimeToExtension().contains(mimeType))
return;
What do you think?
The rest looks good to me :-)
More information about the webkit-reviews
mailing list