[webkit-reviews] review granted: [Bug 27826] [V8] Remove bug-bait V8Proxy::context() : [Attachment 33760] Patch v1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 29 23:50:08 PDT 2009
David Levin <levin at chromium.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 27826: [V8] Remove bug-bait V8Proxy::context()
https://bugs.webkit.org/show_bug.cgi?id=27826
Attachment 33760: Patch v1
https://bugs.webkit.org/attachment.cgi?id=33760&action=review
------- Additional Comments from David Levin <levin at chromium.org>
> Index: WebCore/bindings/v8/V8Proxy.cpp
> + v8::Context::Scope contextScope(m_context);
This is more than just a transform on this line.
This line would be equivalent to what was there before:
v8::Context::Scope contextScope(v8::Local<v8::Context>::New(m_context));
So r+ if you make this change to make it equivalent to before.
More information about the webkit-reviews
mailing list