[webkit-reviews] review denied: [Bug 20565] Drag and drop issues after DOM modifications : [Attachment 33498] Patch to use m_documentUnderMouse instead of element->ownerDocument() when element is NULL.

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Aaron Golden <aegolden at gmail.com>'s
request for review:
Bug 20565: Drag and drop issues after DOM modifications
https://bugs.webkit.org/show_bug.cgi?id=20565

Attachment 33498: Patch to use m_documentUnderMouse instead of
element->ownerDocument() when element is NULL.
https://bugs.webkit.org/attachment.cgi?id=33498&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
This is basically a good patch but it needs a testcase, and i think there
should be an assertion:
> +    if (element) {
	   ASSERT(element->ownerDocument() == m_documentUnderMouse);
> +	   innerFrame = element->ownerDocument()->frame();
> +    } else
> +	   innerFrame = m_documentUnderMouse->frame();
> +    
>      ASSERT(innerFrame);
>  
>      if (dragData->containsColor()) {