[webkit-reviews] review denied: [Bug 27785] [V8] Add a way to register V8 extensions for Isolated Worlds only : [Attachment 33733] rework of above using an extensionGroup tag

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 29 12:53:25 PDT 2009


Adam Barth <abarth at webkit.org> has denied Matt Perry
<mpcomplete at chromium.org>'s request for review:
Bug 27785: [V8] Add a way to register V8 extensions for Isolated Worlds only
https://bugs.webkit.org/show_bug.cgi?id=27785

Attachment 33733: rework of above using an extensionGroup tag
https://bugs.webkit.org/attachment.cgi?id=33733&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This looks good.  The below are only minor style issues:

1) Sometimes we call the value extensionGroup and sometimes extensionFlags.  We
should probably make this consistent.

2) We should put the parameter name in the headers.  Having a bare "int" is
very ambiguous.

Thanks!


More information about the webkit-reviews mailing list